Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete global folder in benchmarks #5523

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jun 24, 2023

What's the problem this PR addresses?

  • 07b4ceb changed the metadata cache structure but didn't update the benchmark script to match.
  • We're not removing the $globalFolder/index folder so install-full-cold is skipping some work.

Follow-up to #5491

How did you fix it?

Clear the entire global folder.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz changed the title chore: clear entire global folder for benchmark chore: delete global folder in benchmarks Jun 24, 2023
@arcanis arcanis merged commit e3a567a into master Jun 24, 2023
@arcanis arcanis deleted the merceyz/chore/benchmark-clear-global-folder branch June 24, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants