Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a timing issue in the way the piping was handled: we were closing the output streams too soon, and that was causing weird race conditions (in Jest it could lead to timeouts, tests reported finished before they actually did, or validation errors within the Node internals). This diff should fix the logic behind it by:
Ensuring that the builtin commands always close their stdout/stderr after they're done writing, except if they're the right-most command (because then they might close the real stdout, which would throw an exception).
Ensuring that the builtin commands always close their stdin after they're done reading, except if they're the left-most command (for a similar reason but this time with the real stdin).