-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): add --metafile
flag
#6212
feat(builder): add --metafile
flag
#6212
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be willing to add it to the bundle
command as well?
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
sure. will push the needed changes in a minute PS: done via 2d6d40a62c8869f0df93999be0c23e8fae50923f |
as requested here: #6212 (review) Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
--metafile
flag
some tests are failing and i do not understand why. |
I've fixed the versions file it was complaining about, the Windows CI has been broken for a while and we haven't gotten around to fixing it yet so you can ignore that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What's the problem this PR addresses?
resolves #6211
...
How did you fix it?
builder build {bundle,plugin}
called--metafile
, defaults tofalse
false
, then theesbuild
in instructed to NOT emitmetafile
true
, then ...esbuild
in instructed to emitmetafile
metafile
data is written to target filebundles/${name}.meta.json
example ourput:
...
Checklist