fix: keep NODE_OPTIONS unset when the calculated value is empty #6255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the type of the process-environment to NodeJS's, which allows undefined as valid value.
What's the problem this PR addresses?
Resolves #6148
How did you fix it?
If the calculated
NODE_OPTIONS
value is an empty string, set the environment value toundefined
.Since the original definition of the process-environment did not allow undefined, I changed the type definition to use
NodeJS.ProcessEnv
. Otherwise the code would need to be written asI haven't figured out where this could be tested, so I did not add/update any unit tests.
Checklist