ci(e2e): fix E2E CRA #6547
Closed
ci(e2e): fix E2E CRA #6547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1tikurisu
force-pushed
the
fix-e2e-cra
branch
from
15fbe83
to
cb64098
Compare
6 tasks
|
There is already a PR fixing this so closing in favour of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
related #6545
The job named "E2E CRA" has failed.
CRA is not supported in Flat Config format（default in ESLint v9）.
ref: facebook/create-react-app#13271
...
How did you fix it?
stopped installing eslint explicitly.
imo: since Create React App is no longer listed in the docs, I don't think there is a need to support it.
instead of, it might be better to support create-next-app
...
Checklist