Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): Make the build/test steps clearer #856

Merged
merged 1 commit into from
Sep 4, 2018
Merged

docs(contributing): Make the build/test steps clearer #856

merged 1 commit into from
Sep 4, 2018

Conversation

edmorley
Copy link
Contributor

@edmorley edmorley commented Sep 3, 2018

Previously it wasn't clear that:

Also adds a "Setup" section covering prerequisites.

Previously it wasn't clear that:
* yarn needs to be built before running tests (since the integration
  tests otherwise fail; see also yarnpkg/yarn#6351).
* `yarn watch` can be run even without the first `yarn build`.
* `yarn test` actually runs the linters too.

Also adds a "Setup" section covering prerequisites.
@Haroenv
Copy link
Member

Haroenv commented Sep 3, 2018

Deploy preview for yarnpkg ready!

Built with commit 4fc143c

https://deploy-preview-856--yarnpkg.netlify.com

@Haroenv Haroenv merged commit a359efa into yarnpkg:master Sep 4, 2018
@Haroenv
Copy link
Member

Haroenv commented Sep 4, 2018

thank you!

@edmorley edmorley deleted the contributing-improvements branch September 4, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants