Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integrity check broke] Always linking, never "up to date" #2859

Closed
borekb opened this issue Mar 7, 2017 · 11 comments
Closed

[integrity check broke] Always linking, never "up to date" #2859

borekb opened this issue Mar 7, 2017 · 11 comments
Assignees

Comments

@borekb
Copy link

borekb commented Mar 7, 2017

Yarn v0.21.3 on Windows 10.

Wild guess:

warning fsevents@1.0.17: The platform "win32" is incompatible with this module.
info "fsevents@1.0.17" is an optional dependency and failed compatibility check. Excluding it from installation.

is causing "linking" dependencies on all runs of yarn making it slow.


Full details:

On most projects, the first yarn is slow as it downloads dependencies but subsequent yarns are fast, something like:

$ yarn
yarn install v0.21.3
[1/4] Resolving packages...
success Already up-to-date.
Done in 1.21s.

However, on one particular project, yarn is always slow, most of the time spent on "linking" dependencies:

$ yarn
yarn install v0.21.3
[1/4] Resolving packages...
[2/4] Fetching packages...
warning fsevents@1.0.17: The platform "win32" is incompatible with this module.
info "fsevents@1.0.17" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 103.04s.

$ yarn
yarn install v0.21.3
[1/4] Resolving packages...
[2/4] Fetching packages...
warning fsevents@1.0.17: The platform "win32" is incompatible with this module.
info "fsevents@1.0.17" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 72.80s.

$ yarn
yarn install v0.21.3
[1/4] Resolving packages...
[2/4] Fetching packages...
warning fsevents@1.0.17: The platform "win32" is incompatible with this module.
info "fsevents@1.0.17" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 81.77s.

Perhaps related report in another issue: #990 (comment).

@bestander bestander self-assigned this Mar 8, 2017
@bestander
Copy link
Member

Need repro steps please

@mcissel
Copy link

mcissel commented Mar 8, 2017

steps to reproduce:

  1. create a new package.json in an empty folder
  2. yarn add chimp
  3. yarn install

You won't get:

[1/4] Resolving packages...
success Already up-to-date.
Done in 0.23s.

You'll get:

[1/4] Resolving packages...
[2/4] Fetching packages...
warning fsevents@1.1.1: The platform "win32" is incompatible with this module.
info "fsevents@1.1.1" is an optional dependency and failed compatibility check. Excluding it
from installation.
[3/4] Linking dependencies...
████████████░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ 2142/14564█
[4/4] Building fresh packages...
Done in 20.30s.

$ yarn --version
0.21.3

$ node --version
v4.6.1

@borekb
Copy link
Author

borekb commented Mar 8, 2017

@mcissel beat me to it :) Sorry for not providing it in the first place.

@friday
Copy link

friday commented Mar 10, 2017

Also getting this on Ubuntu with Yarn 0.21.3 and Node v6.9.5

I tried downgrading, but it's happening on versions as old as 0.17.4, and if I go older than that things start failing.

@bestander
Copy link
Member

I can repro this.
Looks like integrity check is different at the beginning of install operation and at the end.
I'll work on this in the near future

@bestander bestander changed the title Always linking, never "up to date" [integrity check broke] Always linking, never "up to date" Mar 20, 2017
@bestander
Copy link
Member

The reason is in cucumber@github:xolvio/cucumber-js#v1.3.0-chimp.2 deeper in the tree, it gets partially initialized between resolve and fetch phases.
I am working on changing the content of integrity file, this should fix it.

@jackhamburger
Copy link

I am also having this issue on 0.22 and I'm not quite sure how to resolve it

@bestander
Copy link
Member

0.23.2 should have this fixed

@SuhairZain
Copy link

@bestander
I'm seeing this behavior on 0.27.5. I run rm -rf node_modules && yarn and it does it in 28.29s. Then, if I do yarn, instead of showing Already up to date, it does the whole fetch/link process, but this time in just 7.56s. I have other projects in my system, but none of them have this issue. Do you have any pointers as to what could be the problem?

@bestander
Copy link
Member

bestander commented May 17, 2018 via email

@KVSocial
Copy link

KVSocial commented Feb 7, 2019

we updated to latest version 1.13.0 still giving that same error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants