yarn pack does not honor globs in "files" option of package.json

[jrop]

Do you want to request a feature or report a bug? bug

What is the current behavior?

My package.json "files" option specifies globs as entries:

  "files": [
    "config/**/*.js",
    "lib/**/*.js"
  ]

When I run yarn pack it produces a .tgz file with the following entries:

package
package/.gitignore
package/config/.gitignore
package/files/.gitignore
package/package.json

However, when I run npm pack, it packs the following files instead:

package/package.json
package/lib/file1.js
package/lib/file2.js
package/lib/index.js
package/config/index.js
package/config/config1.js
package/config/config2.js

If the current behavior is a bug, please provide the steps to reproduce.
See above

What is the expected behavior?
See the npm pack output

Please mention your node.js, yarn and operating system version.
node: v7.7.3
yarn: v0.23.4
OS: macOS Sierra 10.12.2

[jrop]

Keeping notes for myself:

yarn pack eventually calls: this line with the following filters:

[ { base: '.',
    isNegation: true,
    regex: /^(?:\/(?=.)package\.json)$/i },
  { base: '.',
    isNegation: true,
    regex: /^(?:\/(?=.)readme[^\/]*?)$/i },
  { base: '.',
    isNegation: true,
    regex: /^(?:\/(?!\.)(?=.)(?:license|licence)+[^\/]*?)$/i },
  { base: '.',
    isNegation: true,
    regex: /^(?:\/(?!\.)(?=.)(?:changes|changelog|history)+[^\/]*?)$/i },
  { base: '.',
    isNegation: false,
    regex: /^(?:(?!\.)(?=.)[^\/]*?)$/i },
  { base: '.', isNegation: false, regex: /^(?:(?=.)\.[^\/]*?)$/i },
  { base: '.',
    isNegation: true,
    regex: /^(?:(?=.)config\/(?:(?!(?:\/|^)\.).)*?\/(?!\.)(?=.)[^\/]*?\.js)$/i },
  { base: '.',
    isNegation: true,
    regex: /^(?:(?=.)lib\/(?:(?!(?:\/|^)\.).)*?\/(?!\.)(?=.)[^\/]*?\.js)$/i },
  { base: '.',
    isNegation: false,
    regex: /^(?:\/(?=.)node_modules)$/i },
  { base: 'files',
    isNegation: true,
    regex: /^(?:(?=.)\.gitignore)$/i },
  { base: 'files',
    isNegation: false,
    regex: /^(?:(?!\.)(?=.)[^\/]*?)$/i } ]

[jrop]

More notes: it ends up calling to here with the following context:

filter = { base: '.',
  isNegation: true,
  regex: /^(?:(?=.)lib\/(?:(?!(?:\/|^)\.).)*?\/(?!\.)(?=.)[^\/]*?\.js)$/i }
basename = 'myfile.js'
loc = 'lib/myfile.js'
// matchesFilter(...) returns false in this case

[jrop]

So this is effectively console.logging filters from pack.js:

Ignore list:

!/package.json
!/readme*
!/+(license|licence)*
!/+(changes|changelog|history)*
*
.*
!config/**/*.js
!lib/**/*.js
/lib/
/node_modules/
!.gitignore

[jrop]

Interesting:

const mm = require('minimatch')
const loc = 'lib/sftp.js'
const re = mm.makeRe('lib/**/*.js', {nocase: true})

re.test(loc) // => false
mm(loc, 'lib/**/*.js', {nocase: true}) // => true

minimatch version: 3.0.3

[jrop]

See this line (#648) in minimatch.js

[bestander]

Send a PR with tests please :)

[jrop]

@bestander I have a PR here: /pull/3339, and per your request I have added a fixture + a test that tests this. I am having trouble getting the tests to pass: sometimes an async timeout error is thrown. Is that normal?

[bestander]

Yeah, I am ashamed that our tests are flaky sometimes.
Just don't have time to make them more robust.