Implements "yarn node"

[arcanis]

Summary

This PR implements a new command called yarn node. It is meant to call Node with the correct environment to run the application. The main difference with running Node directly is that Yarn will automatically "cd" to the right directory.

Test plan

I manually ran the following commands and checked their outputs:

yarn node
yarn node -p 42
yarn node -- -p 42
yarn node script.js

I haven't written unit tests for this feature because it is relatively small and self-contained, and because I'm currently designing a new architecture for our tests, which will include tests for this feature. I prefer to spend time on this 🙂

[buildsize]

This change will increase the build size from 10.46 MB to 10.46 MB, an increase of 4.26 KB (0%)

File name	Previous Size	New Size	Change
yarn-[version].noarch.rpm	906.58 KB	906.75 KB	174 bytes (0%)
yarn-[version].js	3.94 MB	3.94 MB	1.93 KB (0%)
yarn-legacy-[version].js	4.09 MB	4.09 MB	1.96 KB (0%)
yarn-v[version].tar.gz	911.76 KB	911.9 KB	141 bytes (0%)
yarn_[version]all.deb	673.38 KB	673.44 KB	60 bytes (0%)

[BYK]

I don't fully understand the need for this but I trust you 😃

This is essentially equivalent to having a script inside package.json making use of the $NODE environment variable we have set, right?

[BYK]

Looks like it is time to create ARG_PROXY_COMMANDS = new Set(['run', 'create', 'node']); or add a new field to all commands, proxyArgs: boolean to determine this behavior.

[arcanis]

This is essentially equivalent to having a script inside package.json making use of the $NODE environment variable we have set, right?

Yup! The difference being that it would give us more opportunities to do extra things on the environment if we want to (for example we could imagine logging the require calls to analyze which dependencies are not being used, or stuff like this).

[coleturner]

Could this be used to colocate specific node versions within packages?

[arcanis]

I'm not sure I understand, can you be more specific? :D

…

On Fri, Feb 23, 2018, 10:00 PM Cole Turner ***@***.***> wrote: Could this be used to colocate specific node versions within packages? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5388 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA_Wa2dN7E4ypRYJFX7nvhNzwFBMzFtMks5tXybxgaJpZM4SNmKV> .

[coleturner]

Ah sorry what I mean is that I’ve recently seen some modules include the “node” binary as a dependency. Im wondering if this could be used to run that directly. Cheers!

…

On Feb 23, 2018, at 6:34 PM, Maël Nison ***@***.***> wrote: I'm not sure I understand, can you be more specific? :D On Fri, Feb 23, 2018, 10:00 PM Cole Turner ***@***.***> wrote: > Could this be used to colocate specific node versions within packages? > > — > You are receiving this because you modified the open/close state. > > > Reply to this email directly, view it on GitHub > <#5388 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AA_Wa2dN7E4ypRYJFX7nvhNzwFBMzFtMks5tXybxgaJpZM4SNmKV> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.