Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Terminus to also display emojis #7093

Merged
merged 3 commits into from
Mar 18, 2019
Merged

Conversation

DRSDavidSoft
Copy link
Contributor

Summary

add Terminus to the list of supported terminal emulators for emoji

Motivation

Since Terminus is also a xterm.js terminal emulator (same as Hyper), and recently it sets TERM_PROGRAM to Terminus (like how Hyper sets it to Hyper), it is proper for Yarn to display Emojis also on Terminus.

Example

Notice the emoji on the last line:

wmoj

DRSDavidSoft and others added 2 commits March 8, 2019 16:51
add Terminus to the list of supported terminal emulators for emoji
@rally25rs
Copy link
Contributor

@DRSDavidSoft could you add an entry into CHANGELOG.md please. Then I'll get this merged in 👍

@rally25rs rally25rs self-requested a review March 16, 2019 22:51
@DRSDavidSoft
Copy link
Contributor Author

@rally25rs Sure, I added an entry to the CHANGELOG.md. Ready to merge 👌

@rally25rs rally25rs merged commit bba4dce into yarnpkg:master Mar 18, 2019
@DRSDavidSoft DRSDavidSoft deleted the patch-1 branch March 18, 2019 14:19
@rogeriopvl
Copy link
Contributor

@DRSDavidSoft @rally25rs Just a heads up, shouldn't this entry be added in the master section of CHANGELOG.md? It was added under an already released version.

@DRSDavidSoft DRSDavidSoft restored the patch-1 branch March 18, 2019 16:57
@DRSDavidSoft
Copy link
Contributor Author

@rogeriopvl I see that, but in my patch-1 branch, it is in fact listed under master.
Should have I added the entry to the top of the CHANGELOG.md list?

In any case, as you point out, 1.15.2 is missing this PR yet it is listed under 1.15.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants