Skip to content

Commit

Permalink
Drop library dependency on tools
Browse files Browse the repository at this point in the history
This drops the library-level dependency on development tools.
The tools are:
     "github.com/gogo/protobuf/protoc-gen-gogoslick"
     "github.com/golang/mock/mockgen"
     "github.com/kisielk/errcheck"
     "github.com/uber/tchannel-go/thrift/thrift-gen"
     "go.uber.org/thriftrw"
     "go.uber.org/tools/update-license"
     "golang.org/x/lint/golint"
     "golang.org/x/tools/cmd/stringer"
     "honnef.co/go/tools/cmd/staticcheck"

related: uber-go/multierr#35
  • Loading branch information
r-hang committed Apr 15, 2020
1 parent 19799b1 commit edd41d8
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
peer.Chooser, or for the private introspection interface.
- Peer list peer unavailability errors now provide additional context including
the number of assigned peers and whether fail-fast is enabled.
- Drop library dependency on development tools.
### Fixed
- Fixed Streaming Protobuf-flavored-JSON nil pointer panic.
- Log entries for EOF stream messages are now considered successes to avoid
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.1.13
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ADD etc/bin/vendor-build.sh /yarpc/etc/bin/
# Download and cache dependencies in the image so that we're not constantly
# re-downloading them locally.

ADD tools.go go.mod go.sum /yarpc/
ADD tools_test.go go.mod go.sum /yarpc/
RUN go mod download

ADD internal/examples/go.mod /yarpc/internal/examples/
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.1.14
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ADD etc/bin/vendor-build.sh /yarpc/etc/bin/
# Download and cache dependencies in the image so that we're not constantly
# re-downloading them locally.

ADD tools.go go.mod go.sum /yarpc/
ADD tools_test.go go.mod go.sum /yarpc/
RUN go mod download

ADD internal/examples/go.mod /yarpc/internal/examples/
Expand Down
File renamed without changes.

0 comments on commit edd41d8

Please sign in to comment.