Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeat runs of generate create more nested folders due to incorrect isLocale check #56

Closed
huan086 opened this issue Oct 21, 2022 · 1 comment
Closed

Repeat runs of generate create more nested folders due to incorrect isLocale check #56

huan086 opened this issue Oct 21, 2022 · 1 comment
Labels
bug Something isn't working released on @beta

Comments

@huan086
Copy link

huan086 commented Oct 21, 2022

There is the assumption that locale is 2 letter language and 2 letter region in CLI utils

However, language can be 3 letters, and language may be followed by script before region. See Unicode CLDR

Thus, locales such as yue-HK (3 letter language) and zh-Hans (script specified, no region) are not recognized by isLocale and these folders are treated as normal folders and localization logic is run on these files, creating a deeper nested structure on each run of generate. E.g. zh-Hans/zh-Hans, zh-Hans/yue-HK, yue-HK/yue-HK, yue-HK/zh-Hans.

Since isLocale is only used by getAstroPagesPath, and getAstroPagesPath is used only by generate, I would propose the problem be fixed by removing getAstroPagesPath and isLocale, and replacing the logic in generate to check locale against i18next.options.supportedLngs, like in localizePath
@yassinedoghri yassinedoghri added the bug Something isn't working label Nov 6, 2022
yassinedoghri added a commit that referenced this issue Nov 6, 2022
@yassinedoghri
fix(generate): replace isLocale check with user defined locales to pr…
a322edb 
…event nested folders generation

fixes #56
@yassinedoghri yassinedoghri mentioned this issue Nov 6, 2022
Merged
yassinedoghri added a commit that referenced this issue Nov 6, 2022
@yassinedoghri
fix(generate): replace isLocale check with user defined locales to pr…
e65cb92 
…event nested folders generation

fixes #56
yassinedoghri pushed a commit that referenced this issue Nov 6, 2022
@semantic-release-bot
chore(release): 1.0.0-beta.13 [skip ci]
f4fcb1a 
# [1.0.0-beta.13](v1.0.0-beta.12...v1.0.0-beta.13) (2022-11-06)

### Bug Fixes

* add isFileHidden function + tests to prevent missing hidden files ([7dcd0aa](7dcd0aa))
* **generate:** replace isLocale check with user defined locales to prevent nested folders generation ([a598e2e](a598e2e)), closes [#56](#56)
* **i18next-server:** load locale files synchronously ([e7892e2](e7892e2))
* update types import to relative ([#58](#58)) ([44a5422](44a5422))

### Features

* add option to show the default locale in the url ([#51](#51)) ([ea939db](ea939db)), closes [#54](#54)
* add support for route translations ([db5200b](db5200b)), closes [#50](#50) [#29](#29)
* allow implicit key for <Trans> when omitting i18nKey prop ([ff14354](ff14354)), closes [#53](#53)
* simplified API + instanciate i18next both in server and client side ([ed44510](ed44510)), closes [#57](#57) [#46](#46) [#37](#37)

### BREAKING CHANGES

* - defaultLanguage is now defaultLocale
- supportedLanguages is now locales
- i18next config is now split into two configs: `i18nextServer`
and `i18nextClient`
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

🎉 This issue has been resolved in version 1.0.0-beta.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

AliLee0923 pushed a commit to AliLee0923/astro-i18N that referenced this issue Dec 2, 2023
@semantic-release-bot
chore(release): 1.0.0-beta.13 [skip ci]
bec4ddf 
# [1.0.0-beta.13](yassinedoghri/astro-i18next@v1.0.0-beta.12...v1.0.0-beta.13) (2022-11-06)

### Bug Fixes

* add isFileHidden function + tests to prevent missing hidden files ([7dcd0aa](yassinedoghri/astro-i18next@7dcd0aa))
* **generate:** replace isLocale check with user defined locales to prevent nested folders generation ([a598e2e](yassinedoghri/astro-i18next@a598e2e)), closes [#56](yassinedoghri/astro-i18next#56)
* **i18next-server:** load locale files synchronously ([e7892e2](yassinedoghri/astro-i18next@e7892e2))
* update types import to relative ([#58](yassinedoghri/astro-i18next#58)) ([44a5422](yassinedoghri/astro-i18next@44a5422))

### Features

* add option to show the default locale in the url ([#51](yassinedoghri/astro-i18next#51)) ([ea939db](yassinedoghri/astro-i18next@ea939db)), closes [#54](yassinedoghri/astro-i18next#54)
* add support for route translations ([db5200b](yassinedoghri/astro-i18next@db5200b)), closes [#50](yassinedoghri/astro-i18next#50) [#29](yassinedoghri/astro-i18next#29)
* allow implicit key for <Trans> when omitting i18nKey prop ([ff14354](yassinedoghri/astro-i18next@ff14354)), closes [#53](yassinedoghri/astro-i18next#53)
* simplified API + instanciate i18next both in server and client side ([ed44510](yassinedoghri/astro-i18next@ed44510)), closes [#57](yassinedoghri/astro-i18next#57) [#46](yassinedoghri/astro-i18next#46) [#37](yassinedoghri/astro-i18next#37)

### BREAKING CHANGES

* - defaultLanguage is now defaultLocale
- supportedLanguages is now locales
- i18next config is now split into two configs: `i18nextServer`
and `i18nextClient`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released on @beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huan086 @yassinedoghri