Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using React but not using react-i18next #68

Closed
jkjustjoshing opened this issue Nov 14, 2022 · 1 comment
Closed

Error when using React but not using react-i18next #68

jkjustjoshing opened this issue Nov 14, 2022 · 1 comment
Labels
bug Something isn't working released on @beta

Comments

@jkjustjoshing
Copy link
Contributor

jkjustjoshing commented Nov 14, 2022

I have a project where I'm using React components, but I haven't installed/imported react-i18next. I updated astro-i18next and I'm getting an error that react-18next can't be resolved. But I'm not doing any translations in my React components and shouldn't need react-i18next installed. It was working fine on an earlier beta version.

Reproduction

https://stackblitz.com/edit/astro-i18next-react-error

Reproduction steps

  1. Install latest astro-i18next
  2. Install @astrojs/react, react, and react-dom
  3. Create a .jsx file and import it into an astro page file. Don't require any translations in the React file.
  4. Try starting dev server or running a build.

Expected - server starts/builds without errors
Current - error complaining that react-i18next isn't installed.

@yassinedoghri yassinedoghri added the bug Something isn't working label Nov 26, 2022
yassinedoghri added a commit that referenced this issue Nov 26, 2022
…side setups

- add load config key to choose to setup i18next for server side, client side or both
- remove
mandatory react-i18next plugin when react integration is set
- update react example README
-
update AstroI18nextConfig props in README.md

fixes #68
yassinedoghri pushed a commit that referenced this issue Nov 27, 2022
# [1.0.0-beta.14](v1.0.0-beta.13...v1.0.0-beta.14) (2022-11-27)

### Bug Fixes

* expect locales folder to be in astro's publicDir config by default ([ec72ff3](ec72ff3)), closes [#64](#64)
* import localizeUrl in HeadHrefLangs from index for access to astro-i18next runtime config ([5e3b96c](5e3b96c)), closes [#65](#65)
* **trans component:** import utility functions from index ([eea0d5d](eea0d5d))

### Features

* **plugins:** set i18next plugins config for both server and client side setups ([5ddb1c7](5ddb1c7)), closes [#68](#68)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

AliLee0923 pushed a commit to AliLee0923/astro-i18N that referenced this issue Dec 2, 2023
# [1.0.0-beta.14](yassinedoghri/astro-i18next@v1.0.0-beta.13...v1.0.0-beta.14) (2022-11-27)

### Bug Fixes

* expect locales folder to be in astro's publicDir config by default ([ec72ff3](yassinedoghri/astro-i18next@ec72ff3)), closes [#64](yassinedoghri/astro-i18next#64)
* import localizeUrl in HeadHrefLangs from index for access to astro-i18next runtime config ([5e3b96c](yassinedoghri/astro-i18next@5e3b96c)), closes [#65](yassinedoghri/astro-i18next#65)
* **trans component:** import utility functions from index ([eea0d5d](yassinedoghri/astro-i18next@eea0d5d))

### Features

* **plugins:** set i18next plugins config for both server and client side setups ([5ddb1c7](yassinedoghri/astro-i18next@5ddb1c7)), closes [#68](yassinedoghri/astro-i18next#68)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released on @beta
Projects
None yet
Development

No branches or pull requests

2 participants