Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url generate with lastest / char #77

Closed
iozcelik opened this issue Nov 29, 2022 · 5 comments
Closed

Url generate with lastest / char #77

iozcelik opened this issue Nov 29, 2022 · 5 comments
Labels
bug Something isn't working released on @beta

Comments

@iozcelik
Copy link

Url generates with / char and language selector doesn't find the page. If I remove / char, goes the page without any translation.

<select onchange="location = this.value;" class="form-select">
  <option value="/fr/index.html/" selected="true">
          🇫🇷 Français
        </option><option value="/index.html/">
          🇺🇸 English
        </option><option value="/de/index.html/">
          🇩🇪 Deutsch
        </option>
</select>
@yassinedoghri yassinedoghri added bug Something isn't working and removed bug Something isn't working labels Nov 30, 2022
@yassinedoghri
Copy link
Owner

Hey @iozcelik, you should use the localizePath function.

@iozcelik
Copy link
Author

@yassinedoghri I use LanguageSelector component. That is result of it.

@yassinedoghri
Copy link
Owner

I see, thanks for the info. Do you have a reproducible example I can check out?

@iozcelik
Copy link
Author

I handle with custom component at active website which use this library but I will create a public repo for issue.

@yassinedoghri yassinedoghri added the bug Something isn't working label Dec 10, 2022
@yassinedoghri yassinedoghri mentioned this issue Dec 10, 2022
Closed
yassinedoghri added a commit that referenced this issue Dec 24, 2022
@yassinedoghri
fix: remove trailing slash from localized path
6454885 
fixes #77
yassinedoghri added a commit that referenced this issue Dec 25, 2022
@yassinedoghri
fix: remove trailing slash from localized path
f370aef 
fixes #77
yassinedoghri pushed a commit that referenced this issue Jan 8, 2023
@semantic-release-bot
chore(release): 1.0.0-beta.15 [skip ci]
633b593 
# [1.0.0-beta.15](v1.0.0-beta.14...v1.0.0-beta.15) (2023-01-08)

### Bug Fixes

* add levels to Astro.global pattern and scripts' import statements ([9d88d79](9d88d79))
* remove trailing slash from localized path ([1998309](1998309)), closes [#77](#77)
* use fileURLToPath to normalize publicDir pathname accross operating systems ([3c07d6a](3c07d6a)), closes [#79](#79)
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

🎉 This issue has been resolved in version 1.0.0-beta.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Temez1 Temez1 mentioned this issue Feb 8, 2023
Closed
AliLee0923 pushed a commit to AliLee0923/astro-i18N that referenced this issue Dec 2, 2023
@semantic-release-bot
chore(release): 1.0.0-beta.15 [skip ci]
fef0dc2 
# [1.0.0-beta.15](yassinedoghri/astro-i18next@v1.0.0-beta.14...v1.0.0-beta.15) (2023-01-08)

### Bug Fixes

* add levels to Astro.global pattern and scripts' import statements ([9d88d79](yassinedoghri/astro-i18next@9d88d79))
* remove trailing slash from localized path ([1998309](yassinedoghri/astro-i18next@1998309)), closes [#77](yassinedoghri/astro-i18next#77)
* use fileURLToPath to normalize publicDir pathname accross operating systems ([3c07d6a](yassinedoghri/astro-i18next@3c07d6a)), closes [#79](yassinedoghri/astro-i18next#79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released on @beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iozcelik @yassinedoghri