fix: Update LanguageSelector.astro as value must be omitted for boolean attributes in html tags #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibutes in html tags <select> 👎<option value="/" selected='true'> English </option> 👈 Change from this 👍<option value="/" selected> English </option> 👈 to this According HTML5 spec on boolean attributes - https://www.w3.org/TR/2008/WD-html5-20080610/semantics.html#boolean If the attribute is present, its value must either be the empty string or a value that is a case-insensitive match for the attribute's canonical name, with no leading or trailing whitespace.
guinetn
changed the title
guinetn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According HTML5 spec on boolean attributes
If the attribute is present, its value must either be the empty string or a value that is a case-insensitive match for the attribute's canonical name, with no leading or trailing whitespace.
Describe your changes
The code create a single selected attribute instead of a selected='true' as required by the html5 spec.
An empty attribute object is first created.
It is populated with the selected attribute if needed, using js spread syntax.
Finally the attribute object is injected in the option tag.
Fixes
Warnings with html syntax checkers.
Checklist