New rubocop #112
Merged
New rubocop #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancorgs
reviewed
Mar 7, 2024
| @@ -43,6 +43,8 @@ class FormatDialog < ::UI::Dialog | |||
| # | |||
| # @param dasds [Array<Y2S390::Dasd>] list of DASDs to be formatted | |||
| def initialize(dasds) | |||
| super() | |||
There was a problem hiding this comment.
Are we sure this change is safe? It's actually the first real change I have seen (with implications that may go beyond style and readability).
There was a problem hiding this comment.
yes, change is safe and I do not many times for newer rubocop. Basically when you have class that is child of another, rubocop wants you to call its initialize to ensure that it is properly initialized. And I need to use super() as super will pass its arguments and UI::Dialog constructor is without params.
For more such changes see e.g. yast/yast-storage-ng@e76cfb2
|
✔️ Internal Jenkins job #32 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CI for master failing due to old rubocop not working with the ruby on TW.
Solution
update rubocop.