Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shahzaib/kyc 1/error handling for onfido flow #17

Merged
merged 7 commits into from
May 11, 2023
Merged

Shahzaib/kyc 1/error handling for onfido flow #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6410ed5
chore: error message banner for onfido flow
shahzaib-deriv May 11, 2023
f5b8fb9
Merge branch 'evgeniy-wall-376/likhith-wall-379/verification_ux_impro…
shahzaib-deriv May 11, 2023
4ba0537
Ako/ Distinguish dd staging logs (#8569)
ali-hosseini-deriv May 11, 2023
62bd456
Bala/Update messages in stale workflow (#8567)
balakrishna-deriv May 11, 2023
44635a3
Merge branch 'master' of https://github.com/binary-com/deriv-app into…
shahzaib-deriv May 11, 2023
41def34
chore: renamed error message field name
shahzaib-deriv May 11, 2023
957a8f4
Revert "Merge branch 'master' of https://github.com/binary-com/deriv-…
shahzaib-deriv May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions ...s/poi/poi-confirm-with-example-form-container/poi-confirm-with-example-form-container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import React from 'react';
import classNames from 'classnames';
import { Form, Formik, FormikHelpers } from 'formik';
import { GetSettings } from '@deriv/api-types';
import { Checkbox, Loading, Text } from '@deriv/components';
import { Checkbox, HintBox, Loading, Text } from '@deriv/components';
import { Localize, localize } from '@deriv/translations';
import { filterObjProperties, isMobile, toMoment, validLength, validName, WS } from '@deriv/shared';
import { localize } from '@deriv/translations';
import FormBody from 'Components/form-body';
import LoadErrorMessage from 'Components/load-error-message';
import PersonalDetailsForm from 'Components/forms/personal-details-form';
Expand Down Expand Up @@ -66,12 +66,12 @@ const PoiConfirmWithExampleFormContainer = ({

const onSubmit = async (values: TValues, { setStatus, setSubmitting }: FormikHelpers<TValues>) => {
if (checked) return;
setStatus({ msg: '' });
setStatus({ error_msg: '' });
const request = makeSettingsRequest(values);
const data = await WS.setSettings(request);

if (data.error) {
setStatus({ msg: data.error.message });
setStatus({ error_msg: data.error.message });
setSubmitting(false);
} else {
const response = await WS.authorized.storage.getSettings();
Expand Down Expand Up @@ -156,6 +156,7 @@ const PoiConfirmWithExampleFormContainer = ({
isSubmitting,
setFieldValue,
setFieldTouched,
status,
}) => (
<Form className='account-form__poi-confirm-example' onSubmit={handleSubmit}>
<FormBody>
Expand Down Expand Up @@ -188,6 +189,21 @@ const PoiConfirmWithExampleFormContainer = ({
disabled={isSubmitting}
/>
</button>
{status?.error_msg && (
<div className='account-form__poi-confirm-example--status-message'>
<HintBox
icon='IcAlertDanger'
icon_height={16}
icon_width={16}
message={
<Text as='p' size='xxxs'>
<Localize i18n_default_text='Sorry, an internal error occurred. Hit the above checkbox to try again.' />
</Text>
}
is_danger
/>
</div>
)}
</FormBody>
</Form>
)}
Expand Down
5 changes: 5 additions & 0 deletions packages/core/src/sass/app/_common/components/onfido-container.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@
max-width: unset;
}

&--status-message {
margin-top: 1.6rem;
text-align: center;
width: 100%;
}
&_container {
@include desktop() {
border: 1px solid var(--general-active);
Expand Down