Suisin/chore: create effortless login modal #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yauheni-deriv
added a commit
that referenced
this pull request
Apr 1, 2024
…inary-com#12587) * feat: Passkeys init commit * trigger build * fix: resolve conflicts, update package lock * chore: test for useIsPasskeySupported hook * chore: restore jest config * chore: remove unneccesary comment * chore: hook code refactor * chore: upm-405,upm-407,upm-408: not set screen, lern more screen, fetch hook * chore: review comments, fix for jest config * fix: types error * refactor: review comments * refactor: move get passkeys key hook to hooks from api * refactor: remove quill * chore: register passkey, passkeys-list * fix: publicKeyCredential type * chore: added passkey icons * chore: learnmore back button, passkey list css * chore: refactor flow, added status content, styles fix * chore: added name to passkey_register * chore: register request fix * chore: update not-set page * chore: success page content update * chore: added console logs * chore: update icons * chore: code refactor, updates with design * chore: tests for components, code refactor * chore: useregister refactor * fix: unnecessary fragment remove * fix: mock passkey remove * refactor: status handling, test cases * fix: time calculation, consolelog remove * fix: last_used name field * chore: added console log for tracking registration errors * chore: initial test for useRegisterPasskey * chore: passkey modal for errors add * chore: added modal to status component * chore: new icon * chore: effortless login page content * chore: status wrapper refactor * chore: error content config init * chore: removed modal from status component * chore: remove route function refactor, context value removed * chore: error flow and show in modal * chore: style fix for error content * chore: useregister passkey refactor * refactor: content change, hook refactor * chore: never used passkey * chore: implement reload logic * refactor: remove usequery for registration * chore: is passkey_supported fix * chore: test fix, udpate content * Suisin/chore: create effortless login modal (#40) * chore: create effortless login modal * chore: update test case for effortless login modal * chore: learn more effortless login, useshowmodal refactor * chore: fix tests, removed test for useregister * chore: first login modal logic refactor * chore: show effortless page tests * refactor: register hook new logic with additional step, tests * chore: new creation flow * chore: update design * fix: test cases * chore: unnesesary code line remove * chore: review comments * chore: add feature flag for passkeys using growthbook (#41) * chore: add feature flag for passkeys using growthbook * feat: add growthbook feature flag handling * test: modify testcases for useIsPasskeySupported hook * feat: add a condition to check if growthbook feature i loaded and then trigger checkPaaskeySupport * fix: remove comment * fix: remove typecasting and use git add . instead * fix: typo * chore: review comments part 1 * chore: review comments part 2 * fix: growthbook fetching value * chore: null case for passkey feature flag * chore: review comments * chore: review comments * chore: remove isPasskeySupported hook, added logic to client store * fix: test cases * fix: show modal hook test * fix: load passkey list when the feature is off on BE * fix: modal text blinckig, css full height * chore: switch off feature flag, add delay for closing modal * fix: close reminder modal before creation * fix: failing test * chore: feature flag fetching * fix: bullets color for darkmode * chore: exclude errors coming from terminating process by user side * chore: separate root for effortless modal, added network status pop up * chore: trigger build * fix: tests, modal opening * fix: effortless modal in signup, tests * chore: fix modal appearing * fix: analytics connection trigger * fix: move effortless ,odal logic to client store * fix: test for effortless modal * chore: well-known files update --------- Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: utkarsha-deriv <125863995+utkarsha-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Add effortless login modal for passkey project
Screenshots:
Please provide some screenshots of the change.