Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPM-1301] Remove passkey notification when user goes to desktop mode from mobile screen #45

Merged
merged 4 commits into from
Jul 24, 2024
Merged

[UPM-1301] Remove passkey notification when user goes to desktop mode from mobile screen #45

merged 4 commits into from
Jul 24, 2024

Conversation

utkarsha-deriv
Copy link
Collaborator

@utkarsha-deriv utkarsha-deriv commented Jul 23, 2024 •
edited
Loading

Changes:

  • removed the logic of checking is_mobile from reaction to fetchShouldShowPasskeyNotification function
  • set the should_show_passkey_notification value based on the value of response and is_mobile
  • added a trigger for handleClientNotifications whenever should_show_passkey_notification changes
  • Modify the heading for notification, remove !

@utkarsha-deriv utkarsha-deriv marked this pull request as ready for review July 23, 2024 09:24
@amina-deriv amina-deriv merged commit 9ab0c26 into yauheni-deriv:remove_effortless_modal/add_passkey_notification Jul 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amina-deriv amina-deriv amina-deriv approved these changes

@fasihali-deriv fasihali-deriv fasihali-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utkarsha-deriv @amina-deriv @fasihali-deriv