Support parse when start dates are in the past #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, Tickle would throw an error if the start option passed in was in the past with respect to `Date.today`. When attempting to enumerate intervals of dates that have already occurred (in the case of looking backwards in a calendar), it is important to be able to parse Tickle expressions and determine what the next occurrence _was_ as opposed to when it _will be_. While it appears that the parse API already supports a `:now` option, it seems this option is ignored when checking this condition and, instead, a `Date.today` is used. This change simply uses the `:now` as is passed to the `Tickled` object to validate `start_date`. Since `Tickled#now` defaults to `Time.now`, this change is minimal but does add value to the gem. References: yb66#4
antogon
force-pushed
the
support-past-start-dates
branch
from
a57dccb to
1a45b4c
Compare
|
@yb66 Any advice on how I could help expedite this PR/maintain this repo? I am a fan of the functionality it adds. |
|
Hi @antogon, I missed this as I was in the middle of moving when it came in, my sincere apologies. I'll give this a look later today and see what's what. As to helping maintain the repo, you help would be more than welcome, we can chat about that too. iain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, Tickle would throw an error if the
startoption passed in was in the past with respect to
Date.today.When attempting to enumerate intervals of dates that have already
occurred (in the case of looking backwards in a calendar), it is
important to be able to parse Tickle expressions and determine
what the next occurrence was as opposed to when it will be.
While it appears that the parse API already supports a
:nowoption,it seems this option is ignored when checking this condition and,
instead, a
Date.todayis used. This change simply uses the:nowas is passed to the
Tickledobject to validatestart_date. SinceTickled#nowdefaults toTime.now, this change is minimal but doesadd value to the gem.
References: #4