-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cache Misses None Values #20
Fix Cache Misses None Values #20
Conversation
python-version: [ "3.7", "3.8", "3.9", "3.10" ] | ||
django-version: [ "3.2" ] | ||
python-version: [ "3.8", "3.9", "3.10" ] | ||
django-version: [ "4.2" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating these versions to align with what we use in main repo while I'm here. Python 3.7 no longer supported by Django 4.2+ so removed that from matrix.
@Jakeway going to hold off until after code freeze to merge this but once this is merged I'm going to follow these instructions to build a new release in pypi: https://github.com/ycharts/django_cache_helper/blob/master/DEVELOPMENT.md Though I probably don't have the permission to do the twine upload so might need to sync with @kdhamoycharts on doing that. |
Also once this is merged and we create version 1.0.5, will need to create a PR that updates our For some reason can't add any reviewers or assigners to the PR I'm guessing need to update some setting for this repo to enable that for me. |
@kdhamoycharts Looks like I also need an approval from an admin to merge this in and then we'll need to do these steps: https://github.com/ycharts/django_cache_helper/blob/master/DEVELOPMENT.md. Not urgent can do this tomorrow / later in week, but once we do that I can open a PR in |
Overview
How to test
decorators.py
file to a docker container via the path/usr/local/lib/python3.8/dist-packages/cache_helper/decorators.py
and then going into a django shell in that container and confirming this works as intended.decorators.py
here.