Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md to correctly represent ar_moveit.launch.py #25

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

oskarsVismanis
Copy link

I updated the README.md to correctly represent the ar_moveit.launch.py

    declared_arguments.append(
        DeclareLaunchArgument("ar_model",
                              default_value="mk1",
                              choices=["mk1", "mk2", "mk3"],
                              description="Model of AR4"))

although, to be consistent with the rest of the README.md, maybe the default value should be changed to mk3?

@ycheng517
Copy link
Owner

Thanks for the fix! I will change the default to mk3 shortly. I have a personal bias for the mk1 since that's what I have 😄

@ycheng517 ycheng517 merged commit 88f25df into ycheng517:main Nov 14, 2024
@oskarsVismanis oskarsVismanis deleted the feature-branch branch November 15, 2024 08:24
@oskarsVismanis
Copy link
Author

mk1 is also the one available for me, so I'm alright with it staying that way 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants