Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to download LLVM armv7a binary on ARM systems #880

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

cbroxton
Copy link
Contributor

@cbroxton cbroxton commented Dec 2, 2017

Added some code to download the clang+llvm-5.0.0-armv7a-linux-gnueabihf.tar.xz for ARM architecture systems.


This change is Reviewable

@bstaletic
Copy link
Collaborator

Changes thtemselves look :lgtm:, but I have no ARM system to test this on.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@micbou
Copy link
Collaborator

micbou commented Dec 4, 2017

There is no ARM in merging this (sorry for the pun).

:lgtm:

@zzbot r+


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@zzbot
Copy link
Contributor

zzbot commented Dec 4, 2017

📌 Commit e52eefc has been approved by micbou

zzbot added a commit that referenced this pull request Dec 4, 2017
Added code to download LLVM armv7a binary on ARM systems

Added some code to download the clang+llvm-5.0.0-armv7a-linux-gnueabihf.tar.xz for ARM architecture systems.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/880)
<!-- Reviewable:end -->
@zzbot
Copy link
Contributor

zzbot commented Dec 4, 2017

⌛ Testing commit e52eefc with merge f58c1f7...

@zzbot
Copy link
Contributor

zzbot commented Dec 4, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: micbou
Pushing f58c1f7 to master...

@zzbot zzbot merged commit e52eefc into ycm-core:master Dec 4, 2017
@codecov-io
Copy link

codecov-io commented Dec 4, 2017

Codecov Report

Merging #880 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #880      +/-   ##
==========================================
- Coverage   95.01%   94.97%   -0.04%     
==========================================
  Files          79       79              
  Lines        5457     5457              
  Branches      172      172              
==========================================
- Hits         5185     5183       -2     
- Misses        224      226       +2     
  Partials       48       48

zzbot added a commit to ycm-core/YouCompleteMe that referenced this pull request Feb 10, 2018
[READY] Update ycmd

Include the following changes:

 - PR ycm-core/ycmd#789: add support for Windows flags when --driver-mode=cl is given;
 - PR ycm-core/ycmd#848: hide C++ symbols by default;
 - PR ycm-core/ycmd#857: add Java support using jdt.ls;
 - PR ycm-core/ycmd#861: translate libclang error codes to exceptions;
 - PR ycm-core/ycmd#880: support downloading Clang binaries on ARM systems;
 - PR ycm-core/ycmd#883: handle zero column diagnostic from OmniSharp;
 - PR ycm-core/ycmd#884: specify Platform property when compiling OmniSharp;
 - PR ycm-core/ycmd#886: use current working directory in JavaScript completer;
 - PR ycm-core/ycmd#887: update Boost to 1.66.0;
 - PR ycm-core/ycmd#888: update JediHTTP;
 - PR ycm-core/ycmd#889: update Clang to 5.0.1;
 - PR ycm-core/ycmd#891: fix building with system libclang on Gentoo amd64;
 - PR ycm-core/ycmd#904: drop Python 2.6 and Python 3.3 support;
 - PR ycm-core/ycmd#905: calculate the start column when items are not resolved in the language server completer;
 - PR ycm-core/ycmd#912: download Clang binaries from HTTPS;
 - PR ycm-core/ycmd#914: do not try to symlink libclang on Windows.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2902)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants