Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

275 create comment #276

Merged
merged 8 commits into from
Oct 17, 2021
Merged

275 create comment #276

merged 8 commits into from
Oct 17, 2021

Conversation

jmbarbone
Copy link
Contributor

Closes #275

  • Makes changes to parameter checking to allow for integers (as documented)
  • Updates docs to be clear on how height and width should be entered
  • Adds checking for single values and removes the lines that grab the first values of height, width without error/warning
  • Simplifies other checks for comments
  • Adds unit testing

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2021

Codecov Report

Merging #276 (12ccc5a) into master (50495e4) will increase coverage by 0.05%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   66.30%   66.36%   +0.05%     
==========================================
  Files          34       34              
  Lines        8935     8936       +1     
==========================================
+ Hits         5924     5930       +6     
+ Misses       3011     3006       -5     
Impacted Files Coverage Δ
R/asserts.R 72.09% <75.00%> (+6.37%) ⬆️
R/CommentClass.R 46.05% <83.33%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9149764...12ccc5a. Read the comment docs.

Copy link
Collaborator

@JanMarvin JanMarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, only minor nitpicking - otherwise looking good!

NEWS.md Outdated Show resolved Hide resolved
R/asserts.R Show resolved Hide resolved
tests/testthat/test-CommentClass.R Show resolved Hide resolved
@JanMarvin JanMarvin merged commit 120a313 into ycphs:master Oct 17, 2021
@JanMarvin
Copy link
Collaborator

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createComment(width) fails with integers
3 participants