Merge pull request rubocop#11392 from koic/fix_an_incorrect_autocorre…

…ct_for_style_redundant_double_splat_hash_braces Fix an incorrect autocorrect for `Style/RedundantDoubleSplatHashBraces`
ydah · Jan 7, 2023 · 6e3f7c1 · 6e3f7c1
2 parents f9248c8 + 36d8ea7
commit 6e3f7c1
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/...og/fix_an_incorrect_autocorrect_for_style_redundant_double_splat_hash_braces.md b/...og/fix_an_incorrect_autocorrect_for_style_redundant_double_splat_hash_braces.md
@@ -0,0 +1 @@
+* [#11392](https://github.com/rubocop/rubocop/pull/11392): Fix an incorrect autocorrect for `Style/RedundantDoubleSplatHashBraces` using double splat in double splat hash braces. ([@koic][])
diff --git a/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb b/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb
@@ -30,7 +30,7 @@ def on_hash(node)
           return unless double_splat_hash_braces?(grandparent)
 
           add_offense(grandparent) do |corrector|
-            corrector.replace(grandparent, node.pairs.map(&:source).join(', '))
+            corrector.replace(grandparent, node.children.map(&:source).join(', '))
           end
         end
       end

diff --git a/spec/rubocop/cop/style/redundant_double_splat_hash_braces_spec.rb b/spec/rubocop/cop/style/redundant_double_splat_hash_braces_spec.rb
@@ -12,6 +12,17 @@
     RUBY
   end
 
+  it 'registers an offense when using double splat in double splat hash braces' do
+    expect_offense(<<~RUBY)
+      do_something(**{foo: bar, **options})
+                   ^^^^^^^^^^^^^^^^^^^^^^^ Remove the redundant double splat and braces, use keyword arguments directly.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      do_something(foo: bar, **options)
+    RUBY
+  end
+
   it 'does not register an offense when using keyword arguments' do
     expect_no_offenses(<<~RUBY)
       do_something(foo: bar, baz: qux)