Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Pandas 1.5 #1076

Merged
merged 3 commits into from
Oct 3, 2022
Merged

feat: add support for Pandas 1.5 #1076

merged 3 commits into from
Oct 3, 2022

Conversation

akx
Copy link
Contributor

@akx akx commented Sep 29, 2022

Some imports had to be fixed up.

  • make test passes locally with flying colors with Pandas 1.5.

Fixes #1075

Following @sbrugman's review, I also added a new pandas_version_info() function, and at the same time got rid of outdated pandas.__version__ checks (since this library requires Pandas 1.2 since 3524c91).

@akx akx force-pushed the pandas15 branch 5 times, most recently from 0df8805 to 1c065e0 Compare September 29, 2022 11:59
@fabclmnt fabclmnt self-requested a review September 29, 2022 17:11
Copy link
Contributor

@fabclmnt fabclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akx please change the merge for develop branch instead of master.

Also can I ask you to follow the Pr naming pattern.
feat: add support for Pandas 1.5

@akx akx changed the base branch from master to develop September 30, 2022 07:43
@akx akx changed the title Add support for Pandas 1.5 feat: Add support for Pandas 1.5 Sep 30, 2022
@akx akx changed the title feat: Add support for Pandas 1.5 feat: add support for Pandas 1.5 Sep 30, 2022
@akx
Copy link
Contributor Author

akx commented Sep 30, 2022

@fabclmnt Done. Maybe the GitHub default branch should be switched to develop..?

@fabclmnt
Copy link
Contributor

@akx the branch was set to default for master for purposes of examples and tutorial checking in GitHub. Otherwise, when you land in GitHub you'll be facing a branch with examples that are not yet available through PyPI. Unfortunately, it was a common misconception.

I understand it might not be ideal, but it was the choice for now. Thank you for understanding!

@fabclmnt fabclmnt self-requested a review September 30, 2022 19:37
Copy link
Contributor

@fabclmnt fabclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you for your contribution!

tests/unit/test_utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sbrugman sbrugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, couple of small changes.

@akx
Copy link
Contributor Author

akx commented Oct 3, 2022

@sbrugman Changes enacted. Can't re-request review mechanically from some reason, so here's a comment to re-request review 😁

Copy link
Collaborator

@sbrugman sbrugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@sbrugman sbrugman merged commit 2462119 into ydataai:develop Oct 3, 2022
@akx akx deleted the pandas15 branch October 3, 2022 16:07
jtook pushed a commit to jtook/pandas-profiling that referenced this pull request Oct 11, 2022
vascoalramos pushed a commit that referenced this pull request Oct 20, 2022
portellaa pushed a commit that referenced this pull request Oct 20, 2022
vascoalramos pushed a commit that referenced this pull request Oct 20, 2022
vascoalramos pushed a commit that referenced this pull request Oct 21, 2022
vascoalramos pushed a commit that referenced this pull request Oct 21, 2022
chanedwin pushed a commit that referenced this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: support of pandas 1.5
3 participants