-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Pandas 1.5 #1076
Conversation
0df8805
to
1c065e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akx please change the merge for develop branch instead of master.
Also can I ask you to follow the Pr naming pattern.
feat: add support for Pandas 1.5
@fabclmnt Done. Maybe the GitHub default branch should be switched to |
@akx the branch was set to default for I understand it might not be ideal, but it was the choice for now. Thank you for understanding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thank you for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on, couple of small changes.
@sbrugman Changes enacted. Can't re-request review mechanically from some reason, so here's a comment to re-request review 😁 |
The library has required Pandas 1.2+ since 3524c91
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
Some imports had to be fixed up.
make test
passes locally with flying colors with Pandas 1.5.Fixes #1075
Following @sbrugman's review, I also added a new
pandas_version_info()
function, and at the same time got rid of outdatedpandas.__version__
checks (since this library requires Pandas 1.2 since 3524c91).