Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: save load TimeGAN #58

Merged
merged 2 commits into from
Mar 24, 2021
Merged

fix: save load TimeGAN #58

merged 2 commits into from
Mar 24, 2021

Conversation

fabclmnt
Copy link
Contributor

Remove the optimizers from the class object to enable save and load with pickling.

@fabclmnt fabclmnt added the bug Something isn't working label Mar 24, 2021
@fabclmnt fabclmnt self-assigned this Mar 24, 2021
@fabclmnt fabclmnt linked an issue Mar 24, 2021 that may be closed by this pull request
[BUG] Save/Load won't work due to lambda functions #57
Closed
@fabclmnt fabclmnt requested a review from ubabe53 March 24, 2021 16:33
ubabe53
ubabe53 approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@ubabe53 ubabe53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything okay and working!

@fabclmnt fabclmnt merged commit f631807 into master Mar 24, 2021
@fabclmnt fabclmnt deleted the fix/save_load branch March 24, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubabe53 ubabe53 ubabe53 approved these changes

@gmartinsribeiro gmartinsribeiro Awaiting requested review from gmartinsribeiro

Assignees

@fabclmnt fabclmnt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Save/Load won't work due to lambda functions
2 participants
@fabclmnt @ubabe53