Add streamlookup monitoring (dynamic counters) #10280
Conversation
yumkam
force-pushed
the
add-streamlookup-monitoring
branch
from
d0208d1
to
4967983
Compare
yumkam
force-pushed
the
add-streamlookup-monitoring
branch
from
74474f3
to
49c4fdc
Compare
StreamLookupTransformCount is same as GenericLookupCount StreamLookupTransformKeys is same as GenericLookupKeys StreamLookupTransformTimeMs is almost same as GenericLookupAnswerTimeMs (plus expenses on actor message passing, and it expected to be small)
ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp
Show resolved
Hide resolved
ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp
Outdated
Show resolved
Hide resolved
| LruHits = taskCounters->GetCounter("StreamLookupTransformLruHits"); | ||
| LruMiss = taskCounters->GetCounter("StreamLookupTransformLruMiss"); | ||
| CpuTimeUs = taskCounters->GetCounter("StreamLookupTransformCpuTimeUs"); | ||
| Batches = taskCounters->GetCounter("StreamLookupTransformBatchCount"); |
There was a problem hiding this comment.
длинноватые у тебя метки. лучше покороче именовать. это и на трафик влияет и можно упереться в лимиты на длину метки в соломоне
There was a problem hiding this comment.
s/Transform// -- да; вообще говоря, можно ещё s/Lru//, но будет чуть слишком лаконично; на чем ещё сэкономить мне не очевидно (s/(Str|Gen)\w*(Lookup)/$1$2/? но тоже как-то слишком)
There was a problem hiding this comment.
StreamLookup -> SL
Transform можно удалить
There was a problem hiding this comment.
Совсем радикальный вариант:
Count = taskCounters->GetCounter("GLReqs");
Keys = taskCounters->GetCounter("GLKeys");
ResultChunks = taskCounters->GetCounter("GLChunks");
ResultRows = taskCounters->GetCounter("GLRows");
ResultBytes = taskCounters->GetCounter("GLBytes");
AnswerTime = taskCounters->GetCounter("GLAnswerMs");
CpuTime = taskCounters->GetCounter("GLCpuUs");
....
LruHits = taskCounters->GetCounter("SLHits");
LruMiss = taskCounters->GetCounter("SLMiss");
CpuTimeUs = taskCounters->GetCounter("SLCpuUs");
Batches = taskCounters->GetCounter("SLBatches");
но как-то это выглядит совсем уже шифровкой
ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/actors/yql_generic_lookup_actor.cpp
Outdated
Show resolved
Hide resolved
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Adds dq_tasks/operation={query_id}/Lookup* sensors
Changelog category
Additional information
...