Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add enable implicit params flag to table service config" #6682

Conversation

VPolka
Copy link
Collaborator

@VPolka VPolka commented Jul 15, 2024

Reverts #6286
can affect performance

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 10:14:48 UTC Pre-commit check for e513246 has started.
2024-07-15 10:17:49 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-15 10:52:35 UTC Build successful.

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 10:16:43 UTC Pre-commit check for e513246 has started.
2024-07-15 10:19:39 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-15 12:34:42 UTC Build successful.
🔴 2024-07-15 12:41:59 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39532 34281 0 3 5226 22

🟢 2024-07-15 12:42:44 UTC ydbd size 8.1 GiB changed* by -1.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f32d32d merge: e513246 diff diff %
ydbd size 8 690 966 544 Bytes 8 690 965 416 Bytes -1.1 KiB -0.000%
ydbd stripped size 473 654 096 Bytes 473 654 096 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 10:17:07 UTC Pre-commit check for e513246 has started.
2024-07-15 10:20:09 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-15 12:58:19 UTC Build successful.
🔴 2024-07-15 13:01:08 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11001 10411 0 91 324 175

🟢 2024-07-15 13:01:57 UTC ydbd size 5.2 GiB changed* by -3.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f32d32d merge: e513246 diff diff %
ydbd size 5 573 578 584 Bytes 5 573 574 760 Bytes -3.7 KiB -0.000%
ydbd stripped size 1 201 180 592 Bytes 1 201 180 016 Bytes -576 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@VPolka VPolka closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant