Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow memory tracking #6731

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Arrow memory tracking #6731

merged 3 commits into from
Jul 16, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Jul 16, 2024

Changelog entry

...

Changelog category

  • New feature

Additional information

...

@vitstn vitstn requested a review from a team as a code owner July 16, 2024 11:58
@vitstn vitstn added the area/yql YQL query language issues label Jul 16, 2024
@vitstn vitstn requested a review from igormunkin July 16, 2024 11:59
Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 12:01:47 UTC Pre-commit check for a8331c2 has started.
2024-07-16 12:04:49 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-16 12:31:28 UTC Build successful.

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 12:02:23 UTC Pre-commit check for a8331c2 has started.
2024-07-16 12:05:27 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-16 12:46:27 UTC Test run completed, no test results found for commit 6db67bf.
2024-07-16 12:46:50 UTC Check cancelled

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 12:02:27 UTC Pre-commit check for a8331c2 has started.
2024-07-16 12:05:28 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-16 12:46:33 UTC Test run completed, no test results found for commit 6db67bf.
2024-07-16 12:47:11 UTC Check cancelled

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 12:50:10 UTC Pre-commit check for 2fc608a has started.
2024-07-16 12:53:35 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-16 13:20:29 UTC Build successful.

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 12:51:59 UTC Pre-commit check for 2fc608a has started.
2024-07-16 12:55:45 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-16 14:18:13 UTC Test run completed, no test results found for commit cf62fba.
2024-07-16 14:18:20 UTC Check cancelled

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 12:57:46 UTC Pre-commit check for 2fc608a has started.
2024-07-16 13:00:44 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-16 14:18:14 UTC Test run completed, no test results found for commit cf62fba.
2024-07-16 14:18:29 UTC Check cancelled

@vitstn vitstn added the rebase-and-check Rebase PR with the current main and check label Jul 16, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current main and check label Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 16:27:22 UTC Pre-commit check for 5d0dd59 has started.
2024-07-16 16:30:23 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-16 19:02:24 UTC Build successful.
🔴 2024-07-16 19:05:41 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14884 14279 0 91 336 178

🟢 2024-07-16 19:06:29 UTC ydbd size 5.2 GiB changed* by -5.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3de9c00 merge: 5d0dd59 diff diff %
ydbd size 5 549 217 448 Bytes 5 549 212 128 Bytes -5.2 KiB -0.000%
ydbd stripped size 1 195 003 888 Bytes 1 195 011 120 Bytes +7.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 16:27:44 UTC Pre-commit check for 5d0dd59 has started.
2024-07-16 16:30:43 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-16 16:59:24 UTC Build successful.

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 16:27:51 UTC Pre-commit check for 5d0dd59 has started.
2024-07-16 16:30:49 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-16 18:58:08 UTC Build successful.
🔴 2024-07-16 19:08:49 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75940 62484 0 7 13430 19

🟢 2024-07-16 19:09:28 UTC ydbd size 8.0 GiB changed* by -50.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3de9c00 merge: 5d0dd59 diff diff %
ydbd size 8 643 166 608 Bytes 8 643 114 656 Bytes -50.7 KiB -0.001%
ydbd stripped size 470 547 296 Bytes 470 547 872 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitstn, thanks for the patch! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yql YQL query language issues new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants