Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: version 3.0.2 #85

Merged
merged 10 commits into from
Feb 4, 2024
Merged

feat: version 3.0.2 #85

merged 10 commits into from
Feb 4, 2024

Conversation

Schlagonia
Copy link
Collaborator

@Schlagonia Schlagonia commented Jan 31, 2024 •
edited
Loading

Description

v3.0.2 Updates

  • Remove increase and decrease allowance
  • Track just totalAssets instead of idle and debt
  • pass the storage pointer around to all internal functions
  • Round down in max redeem instead of up
  • Lower reporting costs by only minting or burning shares once and not using converTo
  • Remove the MIN_FEE
  • change is{Position} => require{Position} for functions used be modifiers for more correct naming/.
  • Other internal improvements for gas efficiency improvements.

image

Checklist

  • I have run solidity linting
  • I have run the tests on my machine
  • I have followed commitlint guidelines
  • I have rebased my changes to the latest version of the main branch
  • I have updated the SPECIFICATION.md for any relevant changes

Schlagonia and others added 5 commits December 20, 2023 14:49
@Schlagonia
feat: version 302
28f753f
@Schlagonia
fix: remove increase and decrease allowance (#75)
4c7a7a3
@Schlagonia
feat: just track total assets (#73)
293bf91 
* feat: just track total assets

* fix: comments
@Schlagonia
feat: pass the storage pointer (#74)
d23f6d8 
* feat: pass the storage pointer

* chore: rebase

* chore: formatting and comments

* chore: rebase

* fix: formatting functions

* fix: test coverage

* fix: remove lcov file

* fix: ignore coverage file
@Schlagonia
fix: max redeem rounding (#83)
0821426 
* fix: use convert to shares

* fix: tests

* test: add check
@Schlagonia Schlagonia changed the title Dev 302 feat: 3.0.2 Jan 31, 2024
Schlagonia and others added 5 commits January 31, 2024 18:56
@Schlagonia
test: fix invariants
d1fb237
@Schlagonia
fix: formatting (#78)
a3ace32 
* fix: naming

* fix: pack struct (#81)

* fix: pack struct further

* fix: format

* chore: dont use modifier require

* chore: organize

* chore: remove is functions

* chore: add chain id to symbol

* chore: organize

* fix: revert symbol change

* chore: fix symbol bakc
@Schlagonia
fix: minor changes (#82)
a6cb558 
* chore: remove min fee

* fix: tests

* build: cheaper reentrancy

* chore: fix spech

* feat: remove internal preview

* feat: make factory immutable (#87)
@Schlagonia
feat: lower report costs (#76)
037b86c 
* feat: only update unlock date

* feat: dont burn unlocked (#77)

* feat: burn shares once

* feat: dont convert twice

* fix: loss shares to burn

* chore: comments

* fix: report updates

* fix: dont burn unless there is shares

* chore: rebase to storage pointer

* chore: organize reporting

* chore: rebase
@Schlagonia
chore: final formatting and script (#88)
ce24aad 
* fix: solc

* chore: comments

* chore: deployment script

* chore: yarn
@Schlagonia Schlagonia changed the title feat: 3.0.2 feat: version 3.0.2 Feb 3, 2024
@Schlagonia Schlagonia merged commit b2ad48b into master Feb 4, 2024
3 checks passed
@Schlagonia Schlagonia deleted the dev_302 branch February 4, 2024 23:31
@wavey0x
Copy link
Collaborator

wavey0x commented Feb 5, 2024

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fp-crypto fp-crypto fp-crypto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Schlagonia @wavey0x @fp-crypto