Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1334-220] fix: manually use allow list before writes #220

Merged
merged 11 commits into from
Feb 25, 2022

Conversation

jstashh
Copy link
Contributor

@jstashh jstashh commented Feb 5, 2022

No description provided.

@yearn-linear-gh-sync yearn-linear-gh-sync bot changed the title fix: manually use allow list before writes [WEB-1334-220] fix: manually use allow list before writes Feb 5, 2022
@linear
Copy link

linear bot commented Feb 5, 2022

@jstashh jstashh requested a review from FiboApe February 5, 2022 14:00
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2022

size-limit report 📦

Path Size
dist/sdk.cjs.production.min.js 41.13 KB (+0.04% 🔺)
dist/sdk.esm.js 41.86 KB (+0.11% 🔺)

Copy link
Collaborator

@FiboApe FiboApe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just left one comment.

What do you think about adding tests for all of this that we've done?

src/yearn.ts Outdated Show resolved Hide resolved
@jstashh jstashh requested a review from FiboApe February 24, 2022 09:13
@jstashh jstashh merged commit a5edc84 into master Feb 25, 2022
@jstashh jstashh deleted the fix/allow-list-remove-prototype branch February 25, 2022 17:24
jstashh added a commit that referenced this pull request May 31, 2022
* fix: manually use allow list before writes

* chore: remove unused imports

* fix: return error from validation service

* fix: remove disableAllowList variable from context

* fix: add missing context param

* fix: token approve tests

* fix: vault tests

* fix: remove unecessary mocking

* test: add transaction service tests

* test: verify that send and validate functions are not called
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants