Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add test for FeesInterface #285

Merged
merged 3 commits into from
Apr 28, 2022
Merged

test: Add test for FeesInterface #285

merged 3 commits into from
Apr 28, 2022

Conversation

huggingbot
Copy link
Contributor

Description

  • Add test for FeesInterface;
  • Refactor FeeInterface to handle situation without data;

karelianpie
karelianpie reviewed Apr 26, 2022
View reviewed changes
src/interfaces/fees.ts Outdated Show resolved Hide resolved
karelianpie
karelianpie reviewed Apr 26, 2022
View reviewed changes
src/interfaces/fees.ts Outdated Show resolved Hide resolved
karelianpie
karelianpie reviewed Apr 26, 2022
View reviewed changes
src/interfaces/fees.ts Outdated Show resolved Hide resolved
karelianpie
karelianpie reviewed Apr 26, 2022
View reviewed changes
src/interfaces/fees.ts Outdated Show resolved Hide resolved
karelianpie
karelianpie previously approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@karelianpie karelianpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor comments

karelianpie
karelianpie reviewed Apr 26, 2022
View reviewed changes
src/interfaces/fees.ts Outdated Show resolved Hide resolved
@jstashh jstashh merged commit e3fe516 into yearn:master Apr 28, 2022
jstashh pushed a commit that referenced this pull request May 31, 2022
@huggingbot @jstashh
test: Add test for FeesInterface (#285)
3f50cbb 
* test: Add test for FeesInterface

* fix: Apply suggested changes

* fix: Apply suggested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FiboApe FiboApe FiboApe approved these changes

@karelianpie karelianpie karelianpie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huggingbot @karelianpie @FiboApe @jstashh