This repository has been archived by the owner on Feb 8, 2025. It is now read-only.
MAINT: Upgrade pytest as a start to tackling CI errors. #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
force-pushed
the
upgrade_pytest
branch
from
80b1240 to
6dda22f
Compare
OTOH, we are not doing any cleanup this way. Maybe we need to implement our own context manager?
arokem
force-pushed
the
upgrade_pytest
branch
from
deb5085 to
25bf238
Compare
|
I believe this is ready for review/merge, and should fix our nightly tests 🤞 |
|
@36000 : Any chance you could take a quick look? |
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.