This repository has been archived by the owner on Feb 8, 2025. It is now read-only.
[FIX] Add max length constraint, b0 fix #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36000
changed the title
arokem
reviewed
Feb 17, 2023
| yield streamline, s | ||
| else: | ||
| yield streamline | ||
| if len_sl >= self.min_length: |
There was a problem hiding this comment.
Is there any kind of test we can add here, to make sure this is doing the right thing now?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding the FP in this subject with this number of streamlines has always been touchy, so I am not too worried about that.
After these fixes pass the test, we can do a minor release.