Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#248: JoinedText ctors more useful #249

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Conversation

fabriciofx
Copy link
Contributor

As per #248 .

@0crat
Copy link
Collaborator

0crat commented Jun 27, 2017

@fabriciofx I'm not managing this repo, remove the webhook or contact me in Slack //cc @yegor256

@codecov-io
Copy link

Codecov Report

Merging #249 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #249      +/-   ##
============================================
- Coverage     72.17%   72.04%   -0.14%     
  Complexity      367      367              
============================================
  Files           120      120              
  Lines          1161     1159       -2     
  Branches         39       39              
============================================
- Hits            838      835       -3     
- Misses          302      303       +1     
  Partials         21       21
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/text/JoinedText.java 94.11% <100%> (+9.9%) 7 <5> (ø) ⬇️
src/main/java/org/cactoos/func/RetryFunc.java 40% <0%> (-15%) 3% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286b19f...fa8d4a0. Read the comment docs.

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 27, 2017

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit fa8d4a0 into yegor256:master Jun 27, 2017
@rultor
Copy link
Collaborator

rultor commented Jun 27, 2017

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 10min)

@fabriciofx fabriciofx deleted the #248 branch June 27, 2017 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants