Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#251: Let's do ReverseIterableTest use JoinedText #252

Closed
wants to merge 1 commit into from

Conversation

fabriciofx
Copy link
Contributor

As per #251 .

@0crat
Copy link
Collaborator

0crat commented Jun 27, 2017

@fabriciofx I'm not managing this repo, remove the webhook or contact me in Slack //cc @yegor256

@codecov-io
Copy link

Codecov Report

Merging #252 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #252   +/-   ##
=========================================
  Coverage     72.42%   72.42%           
  Complexity      370      370           
=========================================
  Files           121      121           
  Lines          1164     1164           
  Branches         39       39           
=========================================
  Hits            843      843           
  Misses          300      300           
  Partials         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21f88e...c4969c8. Read the comment docs.

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 27, 2017

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 28, 2017

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@yegor256
Copy link
Owner

@fabriciofx looks like Rultor is having problems because of the name of your branch: #251. I would recommend to report this bug to rultor repo and rename the branch.

@fabriciofx
Copy link
Contributor Author

@yegor256 Ok.

@fabriciofx
Copy link
Contributor Author

Closed because this PR was renamed to 251 (PR #259).

@rultor
Copy link
Collaborator

rultor commented Jul 21, 2022

@rultor merge

@fabriciofx @yegor256 Oops, I failed. You can see the full log here (spent 62mon)

Docker container yegor256_cactoos_252 is lost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants