added repo-reasoner as a filter for unmainted repositories #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yegor256 could you check the pr please |
yegor256
reviewed
Jan 5, 2025
steps/discover.sh
Outdated
| @@ -69,6 +69,18 @@ elif [ -z "${REPOS}" ] || [ ! -e "${REPOS}" ]; then | |||
| samples-filter filter "${fargs[@]}" | |||
| rm "${csv}" | |||
| mv "${nosamples}" "${csv}" | |||
|
|
|||
| maintained=${TARGET}/maintained.csv | |||
| declare -a margs=( \ | |||
There was a problem hiding this comment.
@dzhovi why it's indented right?
yegor256
reviewed
Jan 5, 2025
steps/discover.sh
Outdated
| "--model=${GIGACHAT_MODEL}" | ||
| ) | ||
| repo-reasoner filter-unmaintained "${margs[@]}" | ||
| rm "${csv}" |
There was a problem hiding this comment.
@dzhovi may be it's better to keep the original file, but only rename it?
yegor256
reviewed
Jan 5, 2025
steps/discover.sh
Outdated
| "--repositories=${csv}" \ | ||
| "--output=${maintained}" \ | ||
| "--key=${GIGACHAT_KEY}" \ | ||
| "--model=${GIGACHAT_MODEL}" |
There was a problem hiding this comment.
@dzhovi can we ask repo-reasoner to save its logs somewhere? It will be very interesting to see why some repositories were filtered out.
|
@dzhovi looks very good! see some comments above |
This was referenced Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo reasoner requires 2 environment variables: