#748 email notifications on release #749
Conversation
|
@alex-palevsky PR is stable. Please find someone to review it. |
|
Many thanks for the PR, let me find a reviewer for it |
|
@longtimeago review this pull request when possible |
| @Ignore | ||
| public void sendsMail() throws Exception { | ||
| final Postman postman = Mockito.spy(Postman.CONSOLE); | ||
| final Profile profile = this.profile(); |
There was a problem hiding this comment.
avoid using one-time variables, just inline it if it's the only usage
|
@alevohin Very good! Only two small remarks above |
|
@longtimeago thanks! Remarks were fixed. Please review one more time. |
|
@alevohin Thanks! |
|
@rultor please, merge |
@longtimeago Thanks for your request. @yegor256 Please confirm this. |
| */ | ||
| @SuppressWarnings("PMD.UnusedFormalParameter") | ||
| public Mails(final Profile prfl, | ||
| final Postman pstmn) { |
There was a problem hiding this comment.
that's a wrong indentation... 4 spaces always please
|
@alevohin looks perfect, except one small comment above (I would recommend to use this settings.jar for IntelliJ) |
|
@yegor256 wondering how did you find this ... |
|
@yegor256 thank for settings! Please have a look one more time. |
|
@rultor merge it |
|
@longtimeago done, I added 19 mins in payment |
|
@rultor deploy now pls |
@alex-palevsky OK, I'll try to deploy now. You can check the progress here |
@alex-palevsky Done! FYI, the full log is here (took me 6min) |
#748 email notifications on release. Created MailsTest.