Drop unique-string dependency
#94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fregante
commented
Jul 13, 2024
fregante
commented
- Closes Secure temp dir in NodeJS without dependencies #81
fregante
commented
Jul 13, 2024
fregante
commented
Jul 13, 2024
| path.join('configstore', `${id}.json`); | ||
|
|
||
| this._path = options.configPath || path.join(configDirectory, pathPrefix); | ||
| this._path = options.configPath ?? getConfigDirectory(id, options.globalConfigPath); |
There was a problem hiding this comment.
Behavior change:
- a new folder is created for every instantiation of Configstore, whereas until now the folder path was decided once on load
Which behavior is preferable? I can wrap getConfigDirectory in a once call if you want to preserve the previous behavior
There was a problem hiding this comment.
I think that's fine. It's only a fallback anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.