Simplify transform utilities. (#284)

yeoman · Apr 23, 2021 · e262506 · e262506
1 parent fad0054
commit e262506
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/lib/util/transform.js b/lib/util/transform.js
@@ -9,12 +9,10 @@ const {Transform} = require('stream');
 
 class YoResolveError extends WError {}
 
-function passthroughTransform(file, _enc, cb) {
-  this.push(file);
-  cb();
-}
-
-function createFileTransform(transform = passthroughTransform, options = {}) {
+function createFileTransform(
+  transform = (file, _enc, cb) => cb(null, file),
+  options = {}
+) {
   const stream = new Transform({
     objectMode: true,
     ...options,
@@ -64,12 +62,10 @@ function createEachFileTransform(forEach, options = {}) {
       forward();
       return;
     }
-    const mayBePromise = forEach.call(this, file, enc, autoContinue ? undefined : cb);
-    if (mayBePromise && mayBePromise.then) {
-      mayBePromise.then(() => forward()).catch(error => cb(error));
-    } else {
-      forward();
-    }
+    Promise
+      .resolve(forEach.call(this, file, enc, autoContinue ? undefined : cb))
+      .then(() => forward())
+      .catch(error => cb(error));
   });
 }