Support for multi-word command line arguments #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, npm test passes but nsp throws an error. Not sure what to make of that. |
SBoudrias
reviewed
Aug 31, 2017
lib/environment.js
Outdated
| @@ -506,6 +506,19 @@ class Environment extends EventEmitter { | |||
|
|
|||
| return require.resolve(untildify(moduleId)); | |||
| } | |||
|
|
|||
| splitArgsFromString(argsString) { | |||
There was a problem hiding this comment.
This doesn't need to be on the prototype. Can you move it as a standalone function?
There was a problem hiding this comment.
Where would be a good place to put it?
There was a problem hiding this comment.
The easiest would be to just move it at the top of the file. We can move it elsewhere if we have a need later on.
|
Awesome, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #75 by allowing quote-mark separated command line arguments. It changes the splitting of argument strings to a 2-step process: it first splits the string apart by quotes (any part matching "*"), and then splits parts of the string up further if they are not part of a quote.