Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

Commit

Permalink
fix(app): remove IE8 support
Browse files Browse the repository at this point in the history
Removes the es5-shim and json3 that IE7/8 needed. Angular 1.3 no longer
supports these so keep support for them seems moot.

BREAKING CHANGE: Removed IE8 support files

Fixes #923
  • Loading branch information
eddiemonge committed Feb 2, 2015
1 parent 668c083 commit 7c6f245
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
2 changes: 2 additions & 0 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,8 @@ The following additional modules are available as components on bower, and insta

All of these can be updated with `bower update` as new versions of AngularJS are released.

`json3` and `es5-shim` have been removed as Angular 1.3 has dropped IE8 support and that is the last version that needed these shims. If you still require these, you can include them with: `bower install --save json3 es5-shim`. `wiredep` should add them to your index.html file but if not you can manually add them.

## Configuration
Yeoman generated projects can be further tweaked according to your needs by modifying project files appropriately.

Expand Down
7 changes: 0 additions & 7 deletions templates/common/app/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,6 @@
ga('send', 'pageview');
</script>

<!-- build:js(.) scripts/oldieshim.js -->
<!--[if lt IE 9]>
<script src="bower_components/es5-shim/es5-shim.js"></script>
<script src="bower_components/json3/lib/json3.js"></script>
<![endif]-->
<!-- endbuild -->

<!-- build:js(.) scripts/vendor.js -->
<!-- bower:js -->
<!-- endbower -->
Expand Down
4 changes: 1 addition & 3 deletions templates/common/root/_bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
"name": "<%= _.slugify(_.humanize(appname)) %>",
"version": "0.0.0",
"dependencies": {
"angular": "^<%= ngVer %>",
"json3": "^3.3.0",
"es5-shim": "^4.0.0"<% if (bootstrap) { %>,<% if (!compassBootstrap) { %>
"angular": "^<%= ngVer %>"<% if (bootstrap) { %>,<% if (!compassBootstrap) { %>
"bootstrap": "^3.2.0"<% } else { %>
"bootstrap-sass-official": "^3.2.0"<% } } %><% if (animateModule) { %>,
"angular-animate": "^<%= ngVer %>"<% } %><% if (ariaModule) { %>,
Expand Down

0 comments on commit 7c6f245

Please sign in to comment.