Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

Update/Merge Upstream Gruntfile.js #35

Closed
btford opened this issue Feb 11, 2013 · 17 comments · Fixed by #471
Closed

Update/Merge Upstream Gruntfile.js #35

btford opened this issue Feb 11, 2013 · 17 comments · Fixed by #471
Assignees
Labels

Comments

@btford
Copy link
Contributor

btford commented Feb 11, 2013

https://github.com/yeoman/generator-webapp/blob/master/app/templates/Gruntfile.js

@ghost ghost assigned btford Feb 11, 2013
@sindresorhus
Copy link
Member

Actually need most of the files in that folder: https://github.com/yeoman/generator-webapp/tree/master/app/templates (except index.html, component.json, 404.html).

@btford
Copy link
Contributor Author

btford commented Feb 12, 2013

Thanks! I got most of it, but I need to extensively test stuff now.

@sleeper
Copy link
Contributor

sleeper commented Feb 13, 2013

@btford You'll probably need to sync up again (sorry for that) as I modified weball's Gruntfile.js.

@btford
Copy link
Contributor Author

btford commented Feb 13, 2013

Thanks for the heads up; I'll take a look now.

@sindresorhus
Copy link
Member

Yes, I added some changes now too.

@btford btford closed this as completed Feb 18, 2013
@sindresorhus
Copy link
Member

@btford @passy @kevva can we make sure the Angular is up to sync in every way with webapp? also the opposite way if there is anything useful we can bring back.

@sindresorhus sindresorhus reopened this Apr 10, 2013
@incorvia
Copy link

incorvia commented May 5, 2013

I think this needs to be done again. I posted this issue which seems related: #199

@btford
Copy link
Contributor Author

btford commented May 6, 2013

@sindresorhus this is starting to feel like a bit too much maintenance overhead. Is there some way you think we can abstract this into it's own package? generator-gruntfile or something?

@sindresorhus
Copy link
Member

@btford thought about it, but all the generators does things differently. You don't have to do it though. Should be easy busy work for anyone to do. And it's only now pre1.0. Post-1.0 the gruntfile will be more stable.

@sindresorhus
Copy link
Member

We need to get this updated to latest Gruntfile (especially watch task since regarde is deprecated) and all the other awesomesauce improvements: yeoman/generator-webapp@v0.1.7...master#diff-4

Any takers? @passy @stephenplusplus @robwierzbowski

@stephenplusplus
Copy link
Contributor

@sindresorhus

@robwierzbowski
Copy link

Beat me to it. I guess that gives me time to work on grunt-bower-install.

@sindresorhus
Copy link
Member

you guys are the best :D

@sindresorhus
Copy link
Member

@robwierzbowski Lots of other issues on this repo that could use some love though ;)

@robwierzbowski
Copy link

Gruntfile stuff I'm comfortable with, but most of the angular specific issues are over my head. I'll take a look though 😄.

@sindresorhus
Copy link
Member

@robwierzbowski sure no prob. We're happy for any help we can get :D

manjunathkg pushed a commit to manjunathkg/generator-angular that referenced this issue Jun 6, 2013
Fix incorrect English in quickstart template.
@sindresorhus
Copy link
Member

Would be lovely if anyone were to do this. Lots of improvements in generator-webapp. Just look at the commits ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants