This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
Make gulp work properly #1164
Merged
Make gulp work properly #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a proper title and description. |
|
@sindresorhus not sure about the title. gulp does not work at all so basically I'm trying to fix it. |
| gulp.task('clean:tmp', function (cb) { | ||
| rimraf('./.tmp', cb); | ||
| gulp.task('clean:tmp', function (callback) { | ||
| rimraf('./.tmp', callback); |
There was a problem hiding this comment.
No thanks. cb is the convention name in Node.
Also change `callback` to `cb` to make it consistent.
Ruby sass is not working like this.
|
Still problems and some depends on what tools and what configs you want to use. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typo
add default task
add missing callback arg
Also change
cbtocallbackto make it consistent.switch to libsass
Ruby sass is not working like this.