Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

Create a dedicated spec file for factories #484

Closed
wants to merge 1 commit into from
Closed

Create a dedicated spec file for factories #484

wants to merge 1 commit into from

Conversation

programbo
Copy link

The classified name in the spec works fine for services, but causes tests to fail with factories which have a camelized name. Seems the simplest solution (aside from find & replace every time I generate a factory) is to just have a different spec file for factories.

@eddiemonge
Copy link
Member

Are you sure its not services that fail as those are the ones with the different name, not factories. Also you need to fix the commit message.

@programbo
Copy link
Author

Sorry, I've made a bit of a debacle with this. Big regrets about thinking this was a good idea so late at night.

Isn't it a strange that all the serviceTest function passes _.classify as the nameFn for all of service specs? Especially when only four out five of the services use _.camelize for their actual names. I forgot to include my updated test-file-creation.js in the pull request :\

Is "fix(gen): don't _.classify names in factory specs" a more appropriate commit message (once I get it to not break the build)?

@eddiemonge
Copy link
Member

i would say "fix(app): service uses cameled name"

@@ -0,0 +1,14 @@
'use strict'

describe 'Service: <%= cameledName %>', () ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this maybe also say Factory then?

@ghost ghost assigned eddiemonge Dec 4, 2013
@eddiemonge eddiemonge closed this Dec 6, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants