This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
fix(app) change the script src to lowercase #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ahh, sorry, let me have a look at travis, sorry for bothering. |
|
@zhuangya Tests should be fine, @eddiemonge is looking into that at the moment. I was referring to the commit message. |
|
the commit message doesnt follow the guidelines. although the code this is fixing won't matter in about a week but thank you. if you fix the message we will still land this fix. |
unify the scriptsrc and filename fix #557
|
does it look better now? |
Closed
|
close enough. i modified it slightly |
|
@eddiemonge thank you very much 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.