Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generator-node and generated test #186

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Update generator-node and generated test #186

merged 1 commit into from
Mar 28, 2017

Conversation

mischah
Copy link
Member

@mischah mischah commented Mar 26, 2017 •
edited
Loading

Updates generator and update generated test to use Jest instead of Mocha.

Fixes #183

@mischah
Copy link
Member Author

mischah commented Mar 26, 2017

Question before releasing v3:

Should we replace Mocha with Jest and replace Gulp with npm scripts here as well?

@SBoudrias
Copy link
Member

Yes, we should always run generator-generator on generator-generator repo to make sure build match and update is not too painful :)

@mischah mischah merged commit f811a17 into master Mar 28, 2017
@mischah mischah deleted the v3 branch March 28, 2017 09:39
@mischah mischah mentioned this pull request Mar 28, 2017
Merged
mohdhafis8507
mohdhafis8507 reviewed Mar 17, 2018
View reviewed changes
Copy link

@mohdhafis8507 mohdhafis8507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great..i like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdhafis8507 mohdhafis8507 mohdhafis8507 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mischah @SBoudrias @mohdhafis8507