Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stalled / orphaned processes when offline #115

Closed
jokeyrhyme opened this issue Jun 29, 2017 · 5 comments · Fixed by #156
Closed

Stalled / orphaned processes when offline #115

jokeyrhyme opened this issue Jun 29, 2017 · 5 comments · Fixed by #156
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@jokeyrhyme
Copy link
Contributor

jokeyrhyme commented Jun 29, 2017

Issuehunt badges

@dex4er reported this over here: npm/npm#17453 (comment)

litomore earned $40.00 by resolving this issue!

@sindresorhus
Copy link
Member

Yeah, would make sense to have a timeout in

updateNotifier.checkNpm().then(update => {
that does process.exit() if nothing happens after a set period. Any suggestions what the timeout period should be?

@sindresorhus sindresorhus changed the title stalled / orphaned processes when offline Stalled / orphaned processes when offline Jun 29, 2017
@jokeyrhyme
Copy link
Contributor Author

15 seconds? 30 seconds? I'm trying to imagine what a reasonable request would look like, even over a cellular network

I feel that 60+ seconds would be too long, and less than 5 seconds would be too short

Mental note: @sindresorhus likes Issue titles to be capitalised :P

@sindresorhus
Copy link
Member

I was thinking 30 seconds. Normally the request should be done in less than a second.

@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@IssueHuntBot
Copy link

@sindresorhus has rewarded $28.00 to @LitoMore. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(20%): $8.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants