resolve #134-common-child 문제풀이 및 문서추가 #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonjuan
reviewed
Aug 14, 2019
|
|
||
| return acc; | ||
| }, []); | ||
| row.push(0); |
There was a problem hiding this comment.
let row = s1.reduce(acc => {
acc.push(0);
return acc;
}, []);
row.push(0);이 코드의 의도가 뭔지 궁금합니다.
There was a problem hiding this comment.
s1 사이즈를 사용해 배열을 사전에 초기ㅗㅘ하려는거 입니다
There was a problem hiding this comment.
배열을 초기화 하는 코드는 Array.from, 과 Array.fill 을 사용하는 편이 좋을것 같습니다.
yeonjuan
reviewed
Aug 14, 2019
| */ | ||
|
|
||
| const lca = (string1, string2) => { | ||
| const s1 = (string1.length <= string2.length) ? [...string1] : [...string2]; |
There was a problem hiding this comment.
string1 이 s1 이 될지, string2 가 s1 이될지 불분명해 보이는데. longer, shorter 와 같이 의미있는 이름을 쓰면 더 명확해질것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.